Developer Tools
From Genunix
Code Review
Code reviewers should refer to our static webrev.
The project gate (not yet integrated) is available via Mercurial:
ssh://anon@hg.opensolaris.org/hg/scm-migration/onnv-scm
Task Lists
| Tool | Technical Notes | Code Reviewer | Start Date | Time Estimate | Completion Date | Status Notes |
| cddlchk | May be more strict than the original. | Ready For Code Review | ||||
| copyrightchk | Ready For Code Review | |||||
| findunref | Ready For Code Review | |||||
| hdrchk | Implementation is mostly more strict than before, testing is against "correct" not "prior behaviour" | Ready For Code Review |
| Tool | Technical Notes | Code Reviewer | Start Date | Time Estimate | Completion Date | Status Notes |
| checkpaths | Ready For Code Review | |||||
| cstyle/jstyle | Minor adjustments to indicate success/failure in the exit code. | Ready For Code Review | ||||
| nightly | Darren Moffat | Ready For Code Review | ||||
| sdrop | ksh script. Used by nightly -O to do OpenSolaris deliveries. | Ready For Code Review | ||||
| webrev | ksh script. See also 6446689 in Bugster. Remaining P4 bugs. | Ready For Code Review | ||||
| ws | ksh script. | Ready For Code Review (tested on SWAN by carlsonj, off by richlowe) | ||||
| wx | ksh script. | Ready For Code Review (tested on SWAN by carlsonj, off by richlowe) | ||||
| xref | ksh script and a part that is done using make. | Darren Mofffat | Ready For Code Review (tested by darrenm; script hasn't changed since July 2007) |
| Tool | Technical Notes | Code Reviewer | Start Date | Time Estimate | Completion Date | Status Notes |
| Cadmium (cdm) | Needs mercurial update, several bug fixes, and a handful of RFEs. Help appreciated. Want two reviewers, especially for complex stuff like recommit. | |||||
| DbLookups | Used by cdm (commentchk) and rtichk. | 0.5 wk | Rtichk and comchk tested successfully on SWAN by carlsonj. Ready for preliminary code review, but cleanup appears to be needed. May also need to change for #370. | |||
| gPyFm | filemerge tool. | ON HOLD. Per 2/29/08 meeting, this work is deferred: 'filemerge' is available to Sun engineers; 'meld' is being putback to SFW. If/when work resumes: Needs many bug fixes and much cleanup and testing. | ||||
| hgsetup | Daren Moffat | Ready For Code Review | ||||
| Keywords | Very simple. Checks that SCCS keywords are not used. | Ready For Code Review | ||||
| Rti/rtichk | Current code talks directly over socket to server; should use XML interface instead? Needs code cleanup. | Ready For Code Review (at least preliminary). Xen using and not aware of any problems. Tested by Jim C on SWAN, and is being used in Burlington. Could use clean-up as well as change to use XML interface? | ||||
| wx2hg | Project gate TW->Hg transition tool (no deltas) | Darren Moffat | 9/7/07: In project gate | Ready For Code Review |
| Tool | Technical Notes | Code Reviewer | Start Date | Time Estimate | Completion Date | Status Notes |
| flag day issues | 0.5 wk | |||||
| code review | 1 month |
NOTES:
- Completion Date = Coding complete; code in project gate;
- Ready For Code Review = Coding is believed to be complete for integration into ON; code is in the project gate.
Go back to SCMMigrationTasks
Flag Day Issues
When we put back the tools changes, there will be a window during which developers may be building old workspaces (not synched with the gate) using the new tools, or trying to build new (synched) workspaces using the old tools.
We need to make sure that nothing horrible happens during that window. If the old tools fail to build a new workspace, that may be okay, but it's undesirable. Silently introducing problems is not acceptable. Nor is it acceptable to force developers to resynch their workspaces just so that they can build with the new tools.
Note that nightly(1) now defaults to building with -t. So maybe this is just a matter of telling people to use the right version of nightly(1).
